Selenium: cover #8674 issue in selenium test #10006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reateAndDeleteProjectsTest
…reateAndDeleteProjectsTest
SkorikSergey
added
status/code-review
artaleks9
approved these changes
Jun 12, 2018
dmytro-ndp
reviewed
Jun 12, 2018
| @@ -88,19 +86,27 @@ public void createAndDeleteProjectTest() throws ExecutionException, InterruptedE | |||
| projectSourcePage.selectSample(WEB_JAVA_SPRING); | |||
| projectSourcePage.selectSample(CONSOLE_JAVA_SIMPLE); | |||
| projectSourcePage.clickOnAddProjectButton(); | |||
| projectSourcePage.clickOnAddOrImportProjectButton(); | |||
| projectSourcePage.selectSample(WEB_JAVA_SPRING); | |||
There was a problem hiding this comment.
it seems we are doing it twice.
Could you, please, leave a comment in the code about why we need to import the project and to select the web java spring sample again?
There was a problem hiding this comment.
For the second creation 'web-java-spring-1' project will be created. I will add comment about it.
dmytro-ndp
approved these changes
Jun 12, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds covering an usecase from #8674 issue for tracking regression to CreateAndDeleteProjectsTest selenium test.
What issues does this PR fix or reference?
#9770