Add service discovery of ChePluginEndpoint of sidecar tooling container on k8s/OS infras #10528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2018 17:17
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Add k8s service for each endpoint in ChePlugin to allow accessing ChePluginEndpoint by its name. This allows plugin developers have predictable URLs for their sidecar plugins and access them from other sidecars. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
garagatyi
changed the title
|
ci-test |
benoitf
added
status/code-review
|
ci-test build report: |
l0rd
approved these changes
Jul 25, 2018
mshaposhnik
approved these changes
Jul 25, 2018
ibuziuk
approved these changes
Jul 25, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is designed to be reviewed in a commit-by-commit manner that simplifies diff review.
This PR adds service discovery for ChePluginEndpoints of sidecar tooling containers on K8s/OS infras.
A detailed log of changes:
ChePluginEndpoint by their name. This allows plugin developers
have predictable URLs for their sidecar plugins and access them
from other sidecars.
What issues does this PR fix or reference?
Fixes #9913 , but works only when not affected by #10510
Release Notes
Docs PR