Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader fix #10619

Merged
merged 4 commits into from
Aug 2, 2018
Merged

Loader fix #10619

merged 4 commits into from
Aug 2, 2018

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Aug 1, 2018 •
edited
Loading

What does this PR do?

Contains loader.html fixes for correct reridectUrl validation (check if any server url is a subpart or a redirectUrl)

What issues does this PR fix or reference?

#10349

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 1, 2018
@mshaposhnik
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

riuvshin commented Aug 1, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10619
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mshaposhnik
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

riuvshin commented Aug 2, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10619
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mshaposhnik mshaposhnik merged commit 5446e00 into master Aug 2, 2018
@mshaposhnik mshaposhnik deleted the loader_fix branch August 2, 2018 13:05
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 9, 2018
@benoitf benoitf added this to the 6.10.0 milestone Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mshaposhnik @riuvshin @skabashnyuk @akurinnoy @benoitf