Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an ability to configure whether machine server authentication via cookies is enabled #10763

Merged

Conversation

sleshchenko
Copy link
Member

What does this PR do?

Adds an ability to configure whether authentication via cookies is enabled. The corresponding server config attribute is introduced, it is cookiesAuthEnabled.

What issues does this PR fix or reference?

#10725

Release Notes

Docs PR

@sleshchenko sleshchenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 14, 2018
@sleshchenko sleshchenko self-assigned this Aug 14, 2018
@sleshchenko sleshchenko changed the title Added an ability to configure whether authentication via cookies is enabled Added an ability to configure whether machine server authentication via cookies is enabled Aug 14, 2018
@sleshchenko
Copy link
Member Author

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10763
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@sleshchenko sleshchenko force-pushed the secureServersCookieAuthentication branch from ee93586 to d44ef71 Compare August 15, 2018 05:58
@sleshchenko sleshchenko force-pushed the secureServersCookieAuthentication branch from d44ef71 to c3c682c Compare August 15, 2018 05:59
@sleshchenko sleshchenko merged commit 43066dc into eclipse-che:master Aug 15, 2018
@sleshchenko sleshchenko deleted the secureServersCookieAuthentication branch August 15, 2018 05:59
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 15, 2018
@benoitf benoitf added this to the 6.10.0 milestone Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants