Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clone and yo in Theia image #10960

Merged
2 commits merged into from
Aug 28, 2018
Merged

Fix clone and yo in Theia image #10960

2 commits merged into from
Aug 28, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2018

What does this PR do?

Adds a little script to entrypoint that will write current uid into /etc/passwd and /etc/group

What issues does this PR fix or reference?

#10756
eclipse/che-theia-factory-extension#8

Factory to try https://che.openshift.io/f?id=factoryfv9dkqhzh5xnshvq

peek 2018-08-28 16-40

@ghost ghost requested review from benoitf and riuvshin as code owners August 28, 2018 13:35
@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 28, 2018
for f in "/etc/passwd" "/etc/group"; do
chgrp -R 0 ${f}
chmod -R g+rwX ${f};
done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting looks strange there

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. already approved

@ghost ghost merged commit a59db0a into master Aug 28, 2018
@ghost ghost deleted the fix_uid_theia_image branch August 28, 2018 14:10
@benoitf benoitf added this to the 6.11.0 milestone Aug 28, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 28, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant