Selenium: remove info about known 10177 and 10699 issues #11734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
status/in-progress
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
…leniumTestsFromLanguageserversPackage
SkorikSergey
added
status/code-review
dmytro-ndp
reviewed
Oct 26, 2018
| (ExpectedCondition<Boolean>) | ||
| webDriver -> getAllVisibleTextFromSignaturesContainer().contains(expectedProposal)); | ||
| } | ||
| /// |
dmytro-ndp
reviewed
Oct 26, 2018
| * @param expectedProposal text which should be present in the container | ||
| */ | ||
| public void waitProposalIntoSignaturesContainer(final String expectedProposal) { | ||
| webDriverWaitFactory |
There was a problem hiding this comment.
Let's use seleniumWebDriverHelper here
…leniumTestsFromLanguageserversPackage
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
dmytro-ndp
approved these changes
Oct 26, 2018
artaleks9
approved these changes
Oct 26, 2018
SkorikSergey
deleted the
updateSeleniumTestsFromLanguageserversPackage
branch
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
master#10177 and [Language server] Signature Help feature doesn't work with "(" character #10699 issues;What issues does this PR fix or reference?
#11732