Enable precreate subpaths property by default in templates #12513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property CHE_INFRA_KUBERNETES_PVC_PRECREATE__SUBPATHS is required for PVC cleanup on current versions of Kubernetes/OpenShift. Without the property enabled, subpaths are created in PVCs by Kubernetes when they are needed for pods. However, only the leaf directory created in this way has write permissions for nonroot users. As a result, the cleanup pod cannot delete directories created (e.g. the workspaceX/projects) directory. For more details, see eclipse-che#12445 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
added
kind/bug
ghost
approved these changes
Jan 25, 2019
sleshchenko
approved these changes
Jan 25, 2019
There was a problem hiding this comment.
LGTM
You mentioned that it is needed for work around issue #12445. Should we create an issue to track solution on Kubernetes side and revert it when no work around will be needed?
Sorry If you described it somewhere in your investigation report but I missed it.
ibuziuk
approved these changes
Jan 25, 2019
garagatyi
approved these changes
Jan 25, 2019
|
@sleshchenko There currently isn't an issue on the Kubernetes side for changing this, as far as I can tell. I need to do some more investigation to see if it's worth opening an upstream issue -- my understanding is that kube gives no guarantee for subpaths. |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set
CHE_INFRA_KUBERNETES_PVC_PRECREATE__SUBPATHS=trueby default in deploy scripts for Che. This is necessary to work around issue #12445 (see comment on issue for details)What issues does this PR fix or reference?
#12445