Allow to change preferences with machine token #12637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
che-bot
added
status/code-review
mmorhun
added
kind/task
|
@mmorhun I think we should notify community on email about this change. If nobody will raise any concerns I'm +1. |
skabashnyuk
approved these changes
Feb 11, 2019
sleshchenko
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
Previously, there were available the only workspace related methods or read operation for other API.
With these changes, it is possible with one machine token to modify other workspaces data.
But it's OK for me since there is no more suitable service for storing data by IDE from workspace container.
mshaposhnik
approved these changes
Feb 11, 2019
evidolob
approved these changes
Feb 12, 2019
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows to change (update / replace / delete) user preferences with machine token.
This is done to be able to change user preferences from within a workspace container.
What issues does this PR fix or reference?
#12442