-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devfile support in UD #13198
Add devfile support in UD #13198
Conversation
The following changes should be applied after merging of this PR |
ci-build |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Rebasing to master |
@@ -196,6 +189,39 @@ export class CreateWorkspaceSvc { | |||
}); | |||
} | |||
|
|||
/*createWorkspaceFromDevfile(workspaceDevfile: che.IWorkspaceDevfile, attributes: any): ng.IPromise<che.IWorkspace> { | |||
const namespaceId = this.namespaceSelectorSvc.getNamespaceId(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's for further workspace creation from devfile
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
Pushed re-based and squashed commits. |
Signed-off-by: Anna Shumilova ashumilo@redhat.com
What does this PR do?
What issues does this PR fix or reference?
#13067
Release Notes
Docs PR