Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Duser.home parameter to maven opts in java-maven stack #13453

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

amisevsk
Copy link
Contributor

What does this PR do?

Adds parameter -Duser.home=/home/user to MAVEN_OPTS in the java-maven stack. This is necessary for workspaces running on OpenShift, which are started using an arbitrary UID which is not found in /etc/passwd.

What issues does this PR fix or reference?

#13451

Tested on minishift locally and on che.openshift.io. Have not tested on kubernetes infrastructures, but it shouldn't be a problem.

Adds parameter -Duser.home=/home/user to MAVEN_OPTS in hte java-maven
stack. This is necessary for workspaces running on OpenShift, which are
started using an arbitrary UID which is not found in /etc/passwd.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk amisevsk added the kind/bug Outline of a bug - must adhere to the bug report template. label May 30, 2019
@amisevsk amisevsk requested review from l0rd and ibuziuk May 30, 2019 20:18
@amisevsk amisevsk requested a review from ashumilova as a code owner May 30, 2019 20:18
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but don't forget to backport this change in eclipse/che-devfile-registry

@amisevsk
Copy link
Contributor Author

@l0rd thanks for the reminder -- opened PR eclipse-che/che-devfile-registry#6

@ibuziuk
Copy link
Member

ibuziuk commented Jun 6, 2019

Closing as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants