Add devfile validation to /workspace/devfile endpoint #13472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workspace manager validates the integrity of the devfile before creating the workspace. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
skabashnyuk
reviewed
Jun 4, 2019
...-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceService.java
Outdated
Show resolved
Hide resolved
...-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceService.java
Show resolved
Hide resolved
mshaposhnik
reviewed
Jun 4, 2019
...-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
for the devfile validation during workspace creation. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
metlos
force-pushed
the
validate-devfile-on-create
branch
from
ae6de5d
to
eff4d8e
Compare
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
metlos
force-pushed
the
validate-devfile-on-create
branch
from
eff4d8e
to
c0dcb0a
Compare
|
ci-test |
skabashnyuk
reviewed
Jun 5, 2019
...-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceService.java
Show resolved
Hide resolved
mshaposhnik
reviewed
Jun 5, 2019
...-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceManager.java
Show resolved
Hide resolved
mshaposhnik
approved these changes
Jun 5, 2019
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
sleshchenko
reviewed
Jun 6, 2019
| * @param contentProvider the content provider to use for resolving content references in the | ||
| * devfile | ||
| * @return new workspace instance | ||
| * @throws NullPointerException when either {@code config} or {@code namespace} is null |
There was a problem hiding this comment.
'{@code config}' here looks like copy/paste error
che-bot
added
the
kind/task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/workspace/devfilenow validates the devfile against schema and workspace manager validates the integrity of the devfile before creating the workspace.What issues does this PR fix or reference?
#13315