Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: Correct the e2e selenium tests related to changes on dashboard #13884

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Selenium: Correct the e2e selenium tests related to changes on dashboard #13884

merged 1 commit into from
Jul 17, 2019

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

  • Correct the E2E selenium tests according to the last changes on the dashboard
  • Related selenium tests: CreateAndDeleteProjectsTest, CreateWorkspaceTest

What issues does this PR fix or reference?

@artaleks9 artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Jul 17, 2019
dmytro-ndp
dmytro-ndp approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not to remove empty lines which helps to identify separate tests.

@artaleks9 artaleks9 merged commit e965a9d into master Jul 17, 2019
@artaleks9 artaleks9 deleted the che#13856 branch July 17, 2019 15:21
@l0rd
Copy link
Contributor

l0rd commented Jul 17, 2019

@artaleks9 we have agreed that until the GA PRs need to get approved by endgame owners (c.f. FAQ in the #13637). If you ping us on mattermost/slack you should get an +1 in a few minutes.

@dmytro-ndp dmytro-ndp mentioned this pull request Jul 17, 2019
Merged
@artaleks9 artaleks9 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artaleks9 @l0rd @dmytro-ndp @SkorikSergey