Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the invalid path conversion. (eclipse#14151) #14152

Closed
wants to merge 1 commit into from
Closed

Fix the invalid path conversion. (eclipse#14151) #14152

wants to merge 1 commit into from

Conversation

monaka
Copy link
Member

@monaka monaka commented Aug 8, 2019

What does this PR do?

Fix the invalid path conversion.

What issues does this PR fix or reference?

fixes #14151

@che-bot
Copy link
Contributor

che-bot commented Aug 8, 2019

Can one of the admins verify this patch?

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Aug 8, 2019

Can one of the admins verify this patch?

@monaka
Fix the invalid path conversion. (eclipse#14151)
3a25a8d 
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 8, 2019
@monaka
Copy link
Member Author

monaka commented Aug 8, 2019

After sent this. I noticed it's better to use hashed value by SHA-256 or something instead of using keyName directly. Because keyName isn't supposed to use as the part of filepath. I'll add some code and re-push here.

@ibuziuk ibuziuk mentioned this pull request Aug 8, 2019
Closed
2 tasks
@vparfonov
Copy link
Contributor

fixed here #14156
can be improved in next versions

@vparfonov vparfonov closed this Aug 12, 2019
@monaka
Copy link
Member Author

monaka commented Aug 15, 2019

@vparfonov Sorry for late response. I reviewed #14156. I suppose it won't work fine in case sshPair.name contains unsuitable chars for the path. As far as I inspect, sshPair.name can be set with no character type validation.

@monaka monaka mentioned this pull request Aug 15, 2019
Closed
@vparfonov
Copy link
Contributor

@vparfonov Sorry for late response. I reviewed #14156. I suppose it won't work fine in case sshPair.name contains unsuitable chars for the path. As far as I inspect, sshPair.name can be set with no character type validation.

Make sense, thats why i assumed about improved in next steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk Awaiting requested review from amisevsk

@l0rd l0rd Awaiting requested review from l0rd

@metlos metlos Awaiting requested review from metlos

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

@vparfonov vparfonov Awaiting requested review from vparfonov

@vinokurig vinokurig Awaiting requested review from vinokurig

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In some case, generated paths to each ssh private key in /etc/ssh/config will be mismatch to mount paths.
3 participants
@monaka @che-bot @vparfonov