Implement remote plugin runtime injection #14333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inject remote plugin injection with help of init container and changing plugin container command and arguments Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
amisevsk,
l0rd,
metlos,
mshaposhnik,
nickboldt and
rhopp
as code owners
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
che-bot
added
status/code-review
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
amisevsk
reviewed
Aug 26, 2019
| throws InternalInfrastructureException { | ||
| return chePlugins | ||
| .stream() | ||
| .filter(chePlugin -> "che editor".equals(chePlugin.getType().toLowerCase())) |
There was a problem hiding this comment.
"che editor" should be extracted to a Constant.
| .orElseThrow( | ||
| () -> | ||
| new InternalInfrastructureException( | ||
| "Workspace should has defined at least one editor")); |
There was a problem hiding this comment.
Suggested change
| "Workspace should has defined at least one editor")); | |
| "Workspace should have at least one editor defined")); |
|
|
||
| boolean pluginIsMatched = pluginIsMatchedToPatch(pluginType, pluginPatcher); | ||
|
|
||
| if (pluginIsMatched) { |
There was a problem hiding this comment.
No reason to use the intermediate variable, we could just do if (pluginIsMatchedToPatch(pluginType, pluginPatcher)
| Container k8sContainer = toK8sContainer(container, emptyList()); | ||
|
|
||
| k8sContainer.setCommand(container.getCommand()); | ||
| k8sContainer.setArgs(container.getArgs()); |
There was a problem hiding this comment.
WDYT about adding args and command to k8sContainerResolver instead of doing it manually?
| @@ -651,6 +651,7 @@ private ChePlugin createChePlugin(String name, CheContainer... containers) { | |||
| ChePlugin plugin = new ChePlugin(); | |||
| plugin.setName(name); | |||
| plugin.setPublisher(publisher); | |||
| plugin.setType("Che editor"); | |||
There was a problem hiding this comment.
We should have test cases for the patching process.
davidfestal
requested changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement remote plugin runtime injection :
Inject remote plugin injection with help of init container and changing plugin container command and arguments
What issues does this PR fix or reference?
redhat-developer/rh-che#1449
Needed for #13387
DEPENDS ON RP:
eclipse-che/che-plugin-broker#71
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com