workspace namespace/project placeholders #14524

sparkoo · 2019-09-12T13:20:24Z

What does this PR do?

Adds possibility to use placeholders in namespace for workspace with current-user values. There are currently 2 placeholders <username> and <userid>.

<something> pattern is not definitive. Please comment in case of any concerns or better ideas.

What issues does this PR fix or reference?

#13488

Docs PR

no docs describing installation and workspace strategies exists yet.

che-bot · 2019-09-12T13:46:18Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14524
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-09-12T14:10:58Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14524
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

sparkoo · 2019-09-13T07:51:37Z

Tested with oauth on Minishift OS3.11. Creates namespace/project fine.

che-bot · 2019-09-13T08:56:23Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14524

sparkoo · 2019-09-13T09:09:01Z

ci-build

sparkoo · 2019-09-13T09:17:14Z

Q:

what to do when che is not using OS oauth and ServiceAccount can't create new project? Should we handle it in code? Or let it fail and just document how it must be configured to work?
how we should support it on k8s? Current PR handles also that, but it probably won't work due to lack of permissions. Should we ignore it on k8s at the moment?

che-bot · 2019-09-13T09:23:01Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14524

sleshchenko · 2019-09-13T11:24:36Z

what to do when che is not using OS oauth and ServiceAccount can't create new project? Should we handle it in code? Or let it fail and just document how it must be configured to work?

So, these placeholders may work in such cases:

OpenShift Oauth is configured;
Service account is configured with admin cluster role; <- I'm not sure that it's production use case at all, so maybe for simplification, we should go with: user's related placeholders are supported only when OpenShift Oauth is configured. If yes - then we would be able to report configuration issue earlier: in chectl or che-operator. And of course, it could be handled in the scope of another issue.

how we should support it on k8s? Current PR handles also that, but it probably won't work due to lack of permissions. Should we ignore it on k8s at the moment?

There is an issue (or at least there were discussions) to remove cluster-admin permissions for k8s installation, but currently, Che has such permissions by default https://github.com/eclipse/che/blob/master/deploy/kubernetes/helm/che/templates/cluster-role-binding.yaml

sparkoo · 2019-09-13T14:17:05Z

works fine on minikube. As @sleshchenko mentioned, it will stop working when we remove cluster-admin permission.

…t due to lack of permissions

…rties

che-bot · 2019-09-16T09:40:21Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14524
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-09-16T09:59:59Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14524

dmytro-ndp · 2019-09-16T10:51:20Z

crw-ci-test

che-bot · 2019-09-16T11:02:33Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14524

skabashnyuk

in general looks good

skabashnyuk · 2019-09-16T15:24:50Z

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java

    this.serviceAccountName = serviceAccountName;
    this.clusterRoleName = clusterRoleName;
    this.clientFactory = clientFactory;
  }

+  private boolean hasPlaceholders(String namespaceName) {
+    for (String placeholder : NAMESPACE_NAME_PLACEHOLDERS.keySet()) {


wdyt may be stream-based implementation would look clener?

might be, I don't have strong preference here. I've changed it to stream, but kept it in own method.

che-bot · 2019-09-16T21:53:26Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14524

che-bot · 2019-09-16T22:28:29Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14524
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

sparkoo · 2019-09-16T22:29:58Z

ci-test

che-bot · 2019-09-16T23:08:29Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14524
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

sparkoo · 2019-09-17T09:39:28Z

ci-test

SkorikSergey · 2019-09-17T10:11:23Z

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2316//Selenium_20tests_20report/) doesn't show any regression against this Pull request.

che-bot · 2019-09-17T10:22:04Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14524
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

sleshchenko

LGTM

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java

che-bot · 2019-09-18T23:32:36Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14524

che-bot · 2019-09-19T00:07:46Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14524

sparkoo · 2019-09-19T04:31:41Z

ci-build

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java

sparkoo · 2019-09-19T23:26:15Z

I've tested with cluster-admin role for che serviceaccount. Works fine, same as on k8s.

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Sep 12, 2019

sparkoo changed the title ~~namespace for workspace placeholders~~ 🚧 namespace for workspace placeholders Sep 12, 2019

sparkoo changed the title ~~🚧 namespace for workspace placeholders~~ WIP namespace for workspace placeholders Sep 12, 2019

sparkoo changed the title ~~WIP namespace for workspace placeholders~~ 🚧 namespace for workspace placeholders Sep 12, 2019

sparkoo marked this pull request as ready for review September 13, 2019 09:10

sparkoo requested review from amisevsk, l0rd, metlos, nickboldt, rhopp and sleshchenko as code owners September 13, 2019 09:10

sparkoo added 3 commits September 16, 2019 09:25

namespace for workspace with username and userid placeholders

9bd8a7a

write meaningful error message when failed to create namespace/projec…

b5ddd1e

…t due to lack of permissions

describe placeholders in kubernetes.namespace/openshift.project prope…

4d576d6

…rties

sparkoo requested a review from ibuziuk as a code owner September 16, 2019 09:15

sparkoo changed the title ~~🚧 namespace for workspace placeholders~~ workspace namespace/project placeholders Sep 16, 2019

skabashnyuk reviewed Sep 16, 2019

View reviewed changes

refactor detect placeholders in namespace to stream

60a48c1

sparkoo mentioned this pull request Sep 18, 2019

<workspaceid> placeholder for workspace namespace/project #14585

Closed

sleshchenko approved these changes Sep 18, 2019

View reviewed changes

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java Show resolved Hide resolved

check if namespace name is predefined when evaluating

f7ae2f1

skabashnyuk approved these changes Sep 19, 2019

View reviewed changes

metlos reviewed Sep 19, 2019

View reviewed changes

...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java Show resolved Hide resolved

sparkoo merged commit 6d9cfe6 into eclipse-che:master Sep 19, 2019

sparkoo deleted the namespacePerUser branch September 19, 2019 23:02

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 19, 2019

che-bot added this to the 7.2.0 milestone Sep 19, 2019

sparkoo mentioned this pull request Sep 19, 2019

Support one namespace per user strategy (che.osio like) #13488

Closed

skabashnyuk mentioned this pull request Sep 23, 2019

Document how to use one namespace per user strategy (che.osio like) #14624

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

workspace namespace/project placeholders #14524

workspace namespace/project placeholders #14524

sparkoo commented Sep 12, 2019 •

edited

Loading

che-bot commented Sep 12, 2019

che-bot commented Sep 12, 2019

sparkoo commented Sep 13, 2019 •

edited

Loading

che-bot commented Sep 13, 2019

sparkoo commented Sep 13, 2019

sparkoo commented Sep 13, 2019

che-bot commented Sep 13, 2019

sleshchenko commented Sep 13, 2019

sparkoo commented Sep 13, 2019

che-bot commented Sep 16, 2019

che-bot commented Sep 16, 2019

dmytro-ndp commented Sep 16, 2019

che-bot commented Sep 16, 2019

skabashnyuk left a comment

skabashnyuk Sep 16, 2019

sparkoo Sep 16, 2019

che-bot commented Sep 16, 2019

che-bot commented Sep 16, 2019

sparkoo commented Sep 16, 2019

che-bot commented Sep 16, 2019

sparkoo commented Sep 17, 2019

SkorikSergey commented Sep 17, 2019

che-bot commented Sep 17, 2019

sleshchenko left a comment

che-bot commented Sep 18, 2019

che-bot commented Sep 19, 2019

sparkoo commented Sep 19, 2019

sparkoo commented Sep 19, 2019

workspace namespace/project placeholders #14524

workspace namespace/project placeholders #14524

Conversation

sparkoo commented Sep 12, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Docs PR

che-bot commented Sep 12, 2019

che-bot commented Sep 12, 2019

sparkoo commented Sep 13, 2019 • edited Loading

che-bot commented Sep 13, 2019

sparkoo commented Sep 13, 2019

sparkoo commented Sep 13, 2019

che-bot commented Sep 13, 2019

sleshchenko commented Sep 13, 2019

sparkoo commented Sep 13, 2019

che-bot commented Sep 16, 2019

che-bot commented Sep 16, 2019

dmytro-ndp commented Sep 16, 2019

che-bot commented Sep 16, 2019

skabashnyuk left a comment

Choose a reason for hiding this comment

skabashnyuk Sep 16, 2019

Choose a reason for hiding this comment

sparkoo Sep 16, 2019

Choose a reason for hiding this comment

che-bot commented Sep 16, 2019

che-bot commented Sep 16, 2019

sparkoo commented Sep 16, 2019

che-bot commented Sep 16, 2019

sparkoo commented Sep 17, 2019

SkorikSergey commented Sep 17, 2019

che-bot commented Sep 17, 2019

sleshchenko left a comment

Choose a reason for hiding this comment

che-bot commented Sep 18, 2019

che-bot commented Sep 19, 2019

sparkoo commented Sep 19, 2019

sparkoo commented Sep 19, 2019

sparkoo commented Sep 12, 2019 •

edited

Loading

sparkoo commented Sep 13, 2019 •

edited

Loading