Add component alias into runtime machine if present in origin devfile #14610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
commented
Sep 20, 2019
.../che/workspace/infrastructure/kubernetes/devfile/DockerimageComponentToWorkspaceApplier.java
Show resolved
Hide resolved
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
che-bot
added
status/code-review
mshaposhnik
commented
Sep 20, 2019
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Show resolved
Hide resolved
mshaposhnik
commented
Sep 20, 2019
...main/java/org/eclipse/che/workspace/infrastructure/kubernetes/wsplugins/MachineResolver.java
Show resolved
Hide resolved
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
skabashnyuk
reviewed
Sep 23, 2019
There was a problem hiding this comment.
in general look ok to me. @sleshchenko @metlos @sparkoo wdyt?
.../che/workspace/infrastructure/kubernetes/devfile/DockerimageComponentToWorkspaceApplier.java
Show resolved
Hide resolved
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
sparkoo
reviewed
Sep 23, 2019
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
mshaposhnik
requested review from
amisevsk,
l0rd,
metlos,
nickboldt,
rhopp and
sleshchenko
as code owners
sleshchenko
reviewed
Sep 24, 2019
...main/java/org/eclipse/che/workspace/infrastructure/kubernetes/wsplugins/MachineResolver.java
Show resolved
Hide resolved
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
|
ci-test |
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
metlos
approved these changes
Sep 24, 2019
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds component alias into runtime machine if thay are present in origin devfile
What issues does this PR fix or reference?
#14280
Release Notes
Docs PR