Use che-plugin-broker images 0.24 #15178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use che-plugin-broker images 0.24 to don't override entrypoint for remote plugin endpoint binary. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
l0rd,
nickboldt,
rhopp and
sleshchenko
as code owners
che-bot
added
status/code-review
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
ibuziuk
approved these changes
Nov 13, 2019
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
|
Seems on the Ci build fail, because ci uses master version https://github.com/eclipse/che-parent. Locally build is fine for 7.3.x |
AndrienkoAleksandr
deleted the
useBrokerV0.24ToDontOverrideEntrypointForRemoteBinary
branch
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use che-plugin-broker images 0.24 to don't override entrypoint for remote plugin endpoint binary.
What issues does this PR fix or reference?
#13387
#15099
Docs PR
eclipse-che/che-docs#879
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com