Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UD] Fixed ability to start a workspace after changing its name. #15251

Merged
merged 1 commit into from
Nov 27, 2019
Merged

[UD] Fixed ability to start a workspace after changing its name. #15251

merged 1 commit into from
Nov 27, 2019

Conversation

akurinnoy
Copy link
Contributor

Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com

What does this PR do?

This PR fixes bug which doesn't allow to start or open a workspace immediately after its name was changed. Changing a workspace name triggers updating related views so all links that contains the workspace name became correct.

What issues does this PR fix or reference?

fixes #14762

@akurinnoy akurinnoy added the kind/bug Outline of a bug - must adhere to the bug report template. label Nov 20, 2019
@akurinnoy akurinnoy self-assigned this Nov 20, 2019
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 20, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 20, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 20, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Nov 21, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 21, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@akurinnoy
Copy link
Contributor Author

ci-build

@akurinnoy
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 22, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@evidolob
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 27, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@akurinnoy
Related views get updated after changing a workspace name.
8fffb33 
This fixes the bug which doesn't allow to start a workspace after changing its name.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
Copy link
Contributor Author

Branch has been rebased to master

@che-bot
Copy link
Contributor

che-bot commented Nov 27, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 27, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@dmytro-ndp
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 27, 2019

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@dmytro-ndp
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 27, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@akurinnoy akurinnoy merged commit b38ae91 into master Nov 27, 2019
@akurinnoy akurinnoy deleted the che-14762 branch November 27, 2019 17:22
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 27, 2019
@che-bot che-bot added this to the 7.5.0 milestone Nov 27, 2019
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
@akurinnoy
Related views get updated after changing a workspace name. (#15251)
5f2f50b 
This fixes the bug which doesn't allow to start a workspace after changing its name.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@evidolob evidolob evidolob approved these changes

@olexii4 olexii4 olexii4 approved these changes

@ashumilova ashumilova Awaiting requested review from ashumilova

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@akurinnoy akurinnoy

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

Failure to Start Workspace after Changing Name
6 participants
@akurinnoy @che-bot @evidolob @dmytro-ndp @benoitf @olexii4