Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workspaces for UD #15784

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Fix workspaces for UD #15784

merged 3 commits into from
Jan 23, 2020

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 22, 2020 •
edited
Loading

What does this PR do?

Fix workspace creation flow in the case with more than 30 workspaces.

What issues does this PR fix or reference?

#9752
#15724
#15776

@centos-ci
Copy link

Can one of the admins verify this patch?

@olexii4 olexii4 changed the title Fix workspaces Fix workspaces for UD Jan 22, 2020
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Jan 22, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@olexii4
fix workspace list
19a5de6 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

@olexii4 olexii4 merged commit e8ab082 into master Jan 23, 2020
@olexii4 olexii4 deleted the fix_workspaces branch January 23, 2020 13:10
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 23, 2020
@che-bot che-bot added this to the 7.8.0 milestone Jan 23, 2020
This was referenced Jan 23, 2020
Closed
Closed
@sleshchenko sleshchenko mentioned this pull request Jan 23, 2020
Closed
This was referenced Jan 24, 2020
Closed
Closed
Closed
mshaposhnik pushed a commit that referenced this pull request Jan 27, 2020
@olexii4 @mshaposhnik
Fix workspaces for UD (#15784)
471ec18 
* fix workspace list

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

@ashumilova ashumilova Awaiting requested review from ashumilova

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@olexii4 @centos-ci @che-bot @sleshchenko @akurinnoy