Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade kubernetes-client to 4.9.0 #16345

Merged
merged 13 commits into from
Mar 25, 2020
Merged

Upgrade kubernetes-client to 4.9.0 #16345

merged 13 commits into from
Mar 25, 2020

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Mar 12, 2020 •
edited
Loading

What does this PR do?

[WIP] Upgrade kubernetes-client to 4.8.0
CQs:

Tested

  • minikube version: v1.8.2
  • crc version: 1.7.0+fa7e558

What issues does this PR fix or reference?

Fixes #11981

Release Notes

n/a

Docs PR

TBD

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Mar 12, 2020
@che-bot
Copy link
Contributor

che-bot commented Mar 12, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Mar 13, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Mar 13, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk skabashnyuk changed the title [WIP] Upgrade kubernetes-client to 4.8.0 [WIP] Upgrade kubernetes-client to 4.9.0 Mar 13, 2020
@skabashnyuk
Upgrade kubernetes-client to 4.9.0
170fb10 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk
Merge remote-tracking branch 'upstream/master' into 15395
bbcf021 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk
Cleanup in podmerger
c2ef559 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
PerWorkspacePVCStrategy cleanup
b2d1b74 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
PerWorkspacePVCStrategy cleanup
6335589 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
PerWorkspacePVCStrategy cleanup
f03e5a9 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk
Merge remote-tracking branch 'upstream/master' into 15395
52812bf 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 19, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk
Added transitive dependencies
afe0042 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 19, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@skabashnyuk
Merge remote-tracking branch 'upstream/master' into 15395
18bbd40 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 19, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk skabashnyuk marked this pull request as ready for review March 19, 2020 11:30
@skabashnyuk skabashnyuk changed the title [WIP] Upgrade kubernetes-client to 4.9.0 Upgrade kubernetes-client to 4.9.0 Mar 19, 2020
@skabashnyuk skabashnyuk requested review from mshaposhnik, sleshchenko and sparkoo and removed request for nickboldt, l0rd, rhopp and vparfonov March 19, 2020 11:31
amisevsk
amisevsk approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially happy to see Quantity added to the k8s client.

@skabashnyuk
Merge remote-tracking branch 'upstream/master' into 15395
5cb01d7 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
cleanup
0b348e7 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 23, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Mar 23, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk
Merge remote-tracking branch 'upstream/master' into 15395
df295d2 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
Move dependencies to parent-pom
0b873fd 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk skabashnyuk mentioned this pull request Mar 25, 2020
Merged
13 tasks
@che-bot
Copy link
Contributor

che-bot commented Mar 25, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Mar 25, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk
Copy link
Contributor Author

ci-build

@skabashnyuk
Copy link
Contributor Author

[ci-build]

1 similar comment
@skabashnyuk
Copy link
Contributor Author

[ci-build]

@skabashnyuk skabashnyuk merged commit db46ad4 into eclipse-che:master Mar 25, 2020
@skabashnyuk skabashnyuk deleted the 15395 branch March 25, 2020 10:14
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 25, 2020
@skabashnyuk skabashnyuk mentioned this pull request Apr 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparkoo sparkoo sparkoo approved these changes

@amisevsk amisevsk amisevsk approved these changes

@metlos metlos Awaiting requested review from metlos

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to update kubernetes-client to 4.9.0 version
5 participants
@skabashnyuk @che-bot @sparkoo @sleshchenko @amisevsk