-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust gitconfig in case if git credentials file are going to be mounted into the workspace #17445
Conversation
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
...kspace/infrastructure/kubernetes/provision/secret/GitCredentialStorageFileSecretApplier.java
Show resolved
Hide resolved
...kspace/infrastructure/kubernetes/provision/secret/GitCredentialStorageFileSecretApplier.java
Show resolved
Hide resolved
...kspace/infrastructure/kubernetes/provision/secret/GitCredentialStorageFileSecretApplier.java
Outdated
Show resolved
Hide resolved
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. 2 minor comments
...kspace/infrastructure/kubernetes/provision/secret/GitCredentialStorageFileSecretApplier.java
Outdated
Show resolved
Hide resolved
...kspace/infrastructure/kubernetes/provision/secret/GitCredentialStorageFileSecretApplier.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
What does this PR do?
Adjust gitconfig in case if git credentials file are going to be mounted into the workspace
What issues does this PR fix or reference?
Fixes #17251
Release Notes
n/a
Docs PR
eclipse-che/che-docs#1421