Stabilize some happy path tests at update to the latest Theia #17933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
che-bot
added
the
status/code-review
RomanNikitenko
changed the title
RomanNikitenko
force-pushed
the
theia-upgrade
branch
from
fb35726 to
371c68b
Compare
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
RomanNikitenko
force-pushed
the
theia-upgrade
branch
from
371c68b to
04d0ac4
Compare
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
|
[crw-ci-test] |
che-bot
added
the
kind/task
|
[crw-ci-test] |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
RomanNikitenko
requested review from
l0rd,
musienko-maxim,
nickboldt,
Ohrimenko1988 and
rhopp
as code owners
Katka92
approved these changes
Sep 24, 2020
This was referenced Sep 24, 2020
dmytro-ndp
reviewed
Sep 24, 2020
There was a problem hiding this comment.
Devfile tests have passed successfully against PR https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/basic-MultiUser-Che-check-e2e-tests-against-k8s/2266/
dmytro-ndp
approved these changes
Sep 24, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I provided PR eclipse-che/che-theia#823 to update
che-theiato the latest TheiaHappy path tests were unstable for the PR ^^.
The goal of the current PR is: stabilize some happy path tests at update to the latest Theia.
What issues does this PR fix or reference?
#17550
How to test this PR?
The changes are related to happy path tests, so I think that:
masterbranchPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.