codenvy-447: Remove containers in case failed to create docker instance. #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@skabashnyuk Please take a look |
|
Build # 1353 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1353/ to view the results. |
AndrienkoAleksandr
force-pushed
the
codenvy-447
branch
from
f6041b6 to
e7ce563
Compare
|
ок |
Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
AndrienkoAleksandr
force-pushed
the
codenvy-447
branch
from
e7ce563 to
d25d5db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Realize clean up docker containers in case failed creation docker instance.
What issues does this PR fix or reference?
codenvy/codenvy#447
New Behavior
In case exception on docker instance creation we delete docker container if it was created.
Tests written?
Yes
Docs requirements?
Include the content for all the docs changes required.
@garagatyi please review.
Signed-off-by: Aleksandr Andrienko aandrienko@codenvy.com