-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize che-launcher for perf #2105
Conversation
Build # 71 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/71/ to view the results. |
@TylerJewell 👏 👏 the launcher is really faster now. I have one comment: You are calling 3 times
You could do the same in As a result you will be able to call the functions directly as many times as you need and you should not need to worry to run all the docker run command at the beginning (but just when you need them). |
@l0rd - so I studied this for a bit this morning and concluded that the system would not profit. In order to implement variable check within |
Added a fix for #2102 as well. |
LGTM |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/85/ |
* Optimize che-launcher for perf * Changed test for addresses * fixup! ignore missing interface * fix port view
* Optimize che-launcher for perf * Changed test for addresses * fixup! ignore missing interface * fix port view
* Optimize che-launcher for perf * Changed test for addresses * fixup! ignore missing interface * fix port view
What does this PR do?
This pull request implements optimizations to minimize the number of times that
docker run
is called within theche-launcher
utility. Previously, there were numerous helper functions that have embeddeddocker run
commands. If these functions were repeatedly called, we were launching unnecessary containers when one invocation will do.Also fixes a small error where one of the docker run commands did not have a
--rm
leaving a lot of lingering exited containers on the user's system.Also adds in a build.sh into the directory to perform a build of the image.