Che script improvements #2211
Merged
Che script improvements #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 as well will require #2048 |
TylerJewell
added
the
kind/enhancement
|
@benoitf - this is ready for merge. Can you +1? |
|
yes I already +1 |
|
Those branch conflicts are just due to github never recognizing my CLA status. |
Change-Id: I8524478628144afe7034541bd7b86f7ad8847027 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf
force-pushed
the
che-script-improvements
branch
from
72c6642 to
4866ce6
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/206/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* remove *-container * moved profiles to ~/.che/profiles * Add product names to profile * added env-file to other commands * Simpler docker run syntax * Add changes for che dir, action, test Change-Id: I8524478628144afe7034541bd7b86f7ad8847027 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com> * Rename CHE_FILE into CHE_DIR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1: Moves profiles into
~/.che/profiles/2: Adds syntax for
che dirinstead ofche up.3: Adds syntax for che action and che test.
4: Adds mini product name to output, so CLI can have different names
5: Improved execution of docker_exec command to remove repeated syntax
6: Passed environment file and profile configuration to other containers for reuse
7: Removed dockerfiles and libraries that were put into che-dockerfiles
8: Moved core Che Dockerfile into the repository root