-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE-2158: simplify boxes' design for Dashboard page #2219
Conversation
@@ -1,4 +1,13 @@ | |||
<che-panel che-title="Recent Workspaces" che-title-icon="material-design icon-ic_widgets_24px"> | |||
<div class="dashboard-last-workspaces-content"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple question: we do not need a component there ? this kind of box won't be reused elsewhere ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have my question answered as I'm seing other changes using duplicates of the style so I think we need reusable component there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benoitf added new component for panel used in dashboard view
Build # 207 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/207/ to view the results. |
/** | ||
* @ngdoc directive | ||
* @name dashboard.directive:DashboardPanel | ||
* @description This class is handling the directive of the panel of last used entries in the dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This class is handling the directive of the panel of last used entries in the dashboard."
it can be simple dashboard panel for displaying dashboard entries, not only last used. Example - credit card info, used RAM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description is fixed
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/211/ |
CHE-2158: simplify boxes' design for Dashboard page
CHE-2158: simplify boxes' design for Dashboard page
What does this PR do?
This PR updates design for Dashboard page.
What issues does this PR fix or reference?
#2158
New behavior
PR type
Minor change checklist
Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com