Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-2158: simplify boxes' design for Dashboard page #2219

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR updates design for Dashboard page.

What issues does this PR fix or reference?

#2158

New behavior

screenshot-che

PR type

  • Minor change = no change to existing features or docs

Minor change checklist

  • Tests passed

Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com

@@ -1,4 +1,13 @@
<che-panel che-title="Recent Workspaces" che-title-icon="material-design icon-ic_widgets_24px">
<div class="dashboard-last-workspaces-content">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple question: we do not need a component there ? this kind of box won't be reused elsewhere ?

Copy link
Contributor

@benoitf benoitf Aug 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have my question answered as I'm seing other changes using duplicates of the style so I think we need reusable component there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benoitf added new component for panel used in dashboard view

@codenvy-ci
Copy link

Build # 207 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/207/ to view the results.

/**
* @ngdoc directive
* @name dashboard.directive:DashboardPanel
* @description This class is handling the directive of the panel of last used entries in the dashboard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This class is handling the directive of the panel of last used entries in the dashboard."
it can be simple dashboard panel for displaying dashboard entries, not only last used. Example - credit card info, used RAM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description is fixed

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
@akurinnoy akurinnoy merged commit 31e6692 into master Aug 26, 2016
@akurinnoy akurinnoy added this to the 4.7.0 milestone Aug 26, 2016
@codenvy-ci
Copy link

@akurinnoy akurinnoy deleted the CHE-2158 branch August 26, 2016 14:10
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
CHE-2158: simplify boxes' design for Dashboard page
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
CHE-2158: simplify boxes' design for Dashboard page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants