Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1: Adds
che compile <mvn command>
syntax. Will run any mvn command in a Che directory or sub-module. It uses the codenvy/che-dev container to perform the build command. This is useful for any users that do not have maven or Java setup properly on their computer but want to test doing a build. The performance is about 4x slower than doing it native - but it's more convenient.2: Added in ability to convert any environment variable with the format of CHE_PROPERTY_= into a value that will be inserted into a temporary
che.properties
file that will be used for the Che launcher, Che mount, Che dir, Che dev utilities. If the user provides a CHE_CONF_FOLDER value, then that directory will be used and any CHE_PROPERTY_ values will be ignored. Variables need to include a double underscore__
to be interpreted as a single underscore_
in the property name. Variables need to provide a single underscore "_" to be interpreted as a period.
. For example:3: Refactorings of the Che CLI to make layering in different portions of the docker run syntax so that it's more extensible and reusable by different types of containers.