Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Che CLI compile Che #2239

Merged
merged 2 commits into from
Aug 28, 2016
Merged

Let Che CLI compile Che #2239

merged 2 commits into from
Aug 28, 2016

Conversation

TylerJewell
Copy link

What does this PR do?

1: Adds che compile <mvn command> syntax. Will run any mvn command in a Che directory or sub-module. It uses the codenvy/che-dev container to perform the build command. This is useful for any users that do not have maven or Java setup properly on their computer but want to test doing a build. The performance is about 4x slower than doing it native - but it's more convenient.

2: Added in ability to convert any environment variable with the format of CHE_PROPERTY_= into a value that will be inserted into a temporary che.properties file that will be used for the Che launcher, Che mount, Che dir, Che dev utilities. If the user provides a CHE_CONF_FOLDER value, then that directory will be used and any CHE_PROPERTY_ values will be ignored. Variables need to include a double underscore __ to be interpreted as a single underscore _ in the property name. Variables need to provide a single underscore "_" to be interpreted as a period .. For example:

# This environment variable:
export CHE_PROPERTY_machine_ws__agent_max__start__time__ms=1000

# Is placed into the temporary che.properties as:
machine.ws_agent.max_start_time_ms=1000

3: Refactorings of the Che CLI to make layering in different portions of the docker run syntax so that it's more extensible and reusable by different types of containers.

@codenvy-ci
Copy link

@skabashnyuk
Copy link
Contributor

che compile will work only for che repository? How about upstream repositories like: che-lib, che-parent, che-dependencies. Will I be able to compile them too?

@TylerJewell
Copy link
Author

Needs to be tested. However, the original intent is just the Che repository itself. If anything is missing it would need to be added into the che-dev image to be available for the container to do its job.

@riuvshin
Copy link
Contributor

+1

@TylerJewell TylerJewell merged commit 5d0869c into master Aug 28, 2016
@TylerJewell TylerJewell deleted the cli-add-compile branch August 28, 2016 22:34
@bmicklea bmicklea mentioned this pull request Aug 29, 2016
89 tasks
@bmicklea
Copy link

@TylerJewell please add a milestone.

@TylerJewell TylerJewell added this to the 4.7.0 milestone Aug 30, 2016
@TylerJewell TylerJewell added the kind/enhancement A feature request - must adhere to the feature request template. label Aug 30, 2016
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
* Added compilation

* Added property converter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants