Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Improve WebTerminalTest e2e test to check more test steps #22661

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

SkorikSergey
Copy link
Contributor

@SkorikSergey SkorikSergey commented Nov 8, 2023

What does this PR do?

For now WebTerminalTest test checks only web terminal starting page. We need to add checking step 4 from Test intergration with DWO document.

What issues does this PR fix or reference?

Eclipse Che issue - #22563

How to test this PR?

  1. Install WebTerminal on Openshift from Operator Hub
  2. Start WebTerminalTest test.

Test logs

          ▼ OcpMainPage.waitOpenMainPage
            ‣ DriverHelper.waitVisibility - By(css selector, *[id="page-main-header"])
            ‣ DriverHelper.waitVisibility - element is located and is visible.
            ‣ DriverHelper.waitAndClick - By(xpath, //button[@data-quickstart-id="qs-masthead-cloudshell"])
            ‣ DriverHelper.waitVisibility - By(xpath, //button[@data-quickstart-id="qs-masthead-cloudshell"])
            ‣ DriverHelper.waitVisibility - element is located and is visible.
            ‣ DriverHelper.waitPresence - By(xpath, //*[@class="xterm-helper-textarea"])
            ‣ DriverHelper.waitPresence - polling timed out attempt #1, retrying with 1000ms timeout
            ‣ DriverHelper.waitPresence - polling timed out attempt #2, retrying with 1000ms timeout
            ‣ DriverHelper.waitPresence - polling timed out attempt #3, retrying with 1000ms timeout
            ‣ DriverHelper.waitPresence - polling timed out attempt #4, retrying with 1000ms timeout
            ‣ DriverHelper.waitPresence - polling timed out attempt #5, retrying with 1000ms timeout
    ✔ Open Web Terminal
          ▼ ShellExecutor.executeCommand - oc get user $(oc whoami) -o jsonpath={.metadata.uid}
7a7e552e-28b7-49cf-b6c4-bfc790dbf114          ▼ ShellExecutor.executeCommand - oc get dw -A -l console.openshift.io/terminal=true,controller.devfile.io/creator=7a7e552e-28b7-49cf-b6c4-bfc790dbf114 -o jsonpath='{.items[0].metadata.namespace}'
openshift-terminal          ▼ ShellExecutor.executeCommand - oc get dw -A -l console.openshift.io/terminal=true,controller.devfile.io/creator=7a7e552e-28b7-49cf-b6c4-bfc790dbf114 -o jsonpath='{.items[0].status.devworkspaceId}'
workspace761cd28d480443be          ▼ ShellExecutor.executeCommand - oc exec -n openshift-terminal deploy/workspace761cd28d480443be -c web-terminal-tooling -- oc whoami
admin
          ▼ ShellExecutor.executeCommand - oc whoami
admin
    ✔ Check username is correct

            ‣ Context.deleteAllWorkspacesOnFinish - Property DELETE_WORKSPACE_ON_FAILED_TEST is true - trying to stop and delete all running workspace after test run with API.
          ▼ TestWorkspaceUtil.stopAndDeleteAllRunningWorkspaces
          ▼ ApiUrlResolver.obtainUserNamespace
            ‣ ApiUrlResolver.obtainUserNamespace - USER_NAMESPACE.length = 0, calling kubernetes API
            ‣ DriverHelper.getDriver
            ‣ Context.deleteAllWorkspacesOnFinish - Running workspaces not found
            ‣ DriverHelper.wait - (5000 milliseconds)
            ‣ DriverHelper.quit
            ‣ DriverHelper.getDriver

  2 passing (33s)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. area/qe labels Nov 8, 2023
@SkorikSergey SkorikSergey self-assigned this Nov 8, 2023
@SkorikSergey SkorikSergey marked this pull request as ready for review November 8, 2023 10:32
@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Nov 8, 2023
@SkorikSergey SkorikSergey merged commit c527b61 into main Nov 8, 2023
3 checks passed
@SkorikSergey SkorikSergey deleted the wto branch November 8, 2023 10:41
@che-bot che-bot added target/branch Indicates that a PR will be merged into a branch other than master. kind/task Internal things, technical debt, and to-do tasks to be performed. and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants