CHE-1771: Add Runtime page to Workspace details #2371
Conversation
|
|
||
| this.editorOptions = { | ||
| lineWrapping: true, | ||
| lineNumbers: false, |
There was a problem hiding this comment.
can remove line numbers panel at all - by setting gutters: []
|
Please @akurinnoy attach screenshots or animated gif so we can review the new features here. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/333/ |
|
Build # 348 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/348/ to view the results. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/371/ |
akurinnoy
changed the title
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/372/ |
akurinnoy
force-pushed
the
CHE-1771
branch
2 times, most recently
from
64f3c9b to
d8adcdf
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/397/ |
| this.updateInProgress = false; | ||
| this.lodash = lodash; | ||
|
|
||
| this.port = 0; |
There was a problem hiding this comment.
let port default value be > 1023 - to avoid error message on popup
| let isUsed = ctrl.lodash.some(ctrl.machinesList, (machine) => { | ||
| return newMachineName !== ctrl.machineName && newMachineName === machine.name; | ||
| }); | ||
| return !isUsed; |
There was a problem hiding this comment.
maybe intermediate var not required
|
Build # 405 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/405/ to view the results. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/409/ |
akurinnoy
changed the title
| constructor($q, $log, $scope, $timeout, cheEnvironmentRegistry) { | ||
| this.$q = $q; | ||
| this.$log = $log; | ||
| this.$scope = $scope; |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/414/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/418/ |
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
|
Build # 424 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/424/ to view the results. |
CHE-1771: Add Runtime page to Workspace details
What does this PR do?
This PR adds Runtime page to Workspace details.
Added new dependency which is handled by CQ.
What issues does this PR fix or reference?
#1771 Add Ports section in the workspace configuration
#1772 Add Environment variables in the workspace configuration
#1918 Allow for changes to workspace RAM to existing workspace
#2451 Workspace environment page enhancement
Screenshots
Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com