Add Petclinic+MySQL stack, petclinic mysql sample project. Fix dashbo… #2376
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,74 @@ | ||
| [ | ||
| { | ||
| "id": "java-mysql", | ||
| "creator": "ide", | ||
| "name": "Java-MySQL", | ||
| "description": "Multi-machine environment with Default Java Stack and MySQL database", | ||
| "scope": "general", | ||
| "tags": [ | ||
| "Java 1.8, Tomcat 8, MySQL 5.7" | ||
| ], | ||
| "components": [ | ||
| { | ||
| "name": "JDK", | ||
| "version": "1.8.0_45" | ||
| }, | ||
| { | ||
| "name": "Maven", | ||
| "version": "3.2.2" | ||
| }, | ||
| { | ||
| "name": "Tomcat", | ||
| "version": "8.0.24" | ||
| } | ||
| ], | ||
| "source": { | ||
| "type": "image", | ||
| "origin": "codenvy/ubuntu_jdk8" | ||
| }, | ||
| "workspaceConfig": { | ||
| "environments": { | ||
| "default": { | ||
| "machines": { | ||
| "dev-machine": { | ||
|
There was a problem hiding this comment. Is this the most user friendly name we can give it? Is this the name that shows up in the machine drop down? I think that this name is super clear for us, but perhaps it's not as clear as it could be for new users experiencing the system the first time. There was a problem hiding this comment.
|
||
| "agents": [ | ||
| "ws-agent" | ||
| ], | ||
| "servers": {}, | ||
| "attributes" : {} | ||
| } | ||
| }, | ||
| "recipe": { | ||
| "content": "services:\n db:\n image: codenvy/mysql\n environment:\n MYSQL_DATABASE: petclinic\n MYSQL_USER: petclinic\n MYSQL_PASSWORD: password\n mem_limit: 2147483648\n dev-machine:\n image: codenvy/ubuntu_jdk8\n mem_limit: 2147483648\n links:\n - db", | ||
| "contentType": "application/x-yaml", | ||
| "type": "compose" | ||
| } | ||
| } | ||
| }, | ||
| "name": "default", | ||
| "defaultEnv": "default", | ||
| "description": null, | ||
| "commands": [ | ||
| { | ||
| "commandLine": "mysql -u $MYSQL_USER -p$MYSQL_PASSWORD -e 'show databases;'", | ||
| "name": "show databases", | ||
| "type": "custom" | ||
| } | ||
| ] | ||
| }, | ||
| "acl": [ | ||
| { | ||
| "user": "*", | ||
| "actions": [ | ||
| "search" | ||
| ] | ||
| } | ||
| ], | ||
| "stackIcon": { | ||
| "name": "type-java-mysql.svg", | ||
| "mediaType": "image/svg+xml" | ||
| } | ||
| }, | ||
| { | ||
| "id": "che-in-che", | ||
| "creator": "ide", | ||
|
|
@@ -1467,13 +1537,7 @@ | |
| "description": "Default Java Stack with JDK 8, Maven and Apache TomEE 1.7.3.", | ||
| "scope": "advanced", | ||
| "tags": [ | ||
| "TomEE" | ||
| ], | ||
| "components": [ | ||
| { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the suggestions that I made to Stevan was that we should probably be more complete on the list of components that we have and their versions. We should list all of the libraries that we are installing into the Ubuntu system - so bash, openssl, etc. Anything that we are explicitly installing with a RUN command should probably be added here.
We also need the mysql reference, and I think the JDK / maven versions are out of date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are tags, smth that will show up in user dashboard. We use tags to match stacks and samples.
So, if I like versions of everything, we just do not have space in the stack box on UD.
Also, this will break all the filtering.
This is a UD issue. Perhaps, we should use components to display in UD but use tags that can be super unique but not super readable to match samples.
@ashumilova can comment - we talked about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eivantsov - I think there is a difference between components and tags in this document. The tags are used for filtering and they are a different list of labels. But I believe the components are the list that appears in the UD.
If we have a long list of components, are we concerned about the display height of the stack boxes? @ashumilova - if we have a super long list of components, do we just cut off the list or do we make the box taller? We probably need to think about what to do here.
But I would think that we should go ahead and make the components list complete and then as a secondary measure work on improving the UX display of the stack box?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerJewell Tag appear in UI and they are used to match stacks and filters. Components aren't used at all now in master.
This is a broader question and does not affect this PR only. This is how things work now, you may check with @ashumilova if you have doubts.