Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Maven plugin for generating TypeScript DTO objects based on Java DTO #2490

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Sep 19, 2016

What does this PR do?

It allow javascript clients (like Dashboard and Chefile) of REST API of Eclipse Che to use a Typed variables by using TypeScript definition and implementation

Generation is based on string template library eclipse-che/che-dependencies#17

input :
ouput : dto.ts file including DTO definition and an implementation for building objects around JSON content

usage example

            ...
            <plugin>
                <groupId>org.eclipse.che.core</groupId>
                <artifactId>che-core-typescript-dto-maven-plugin</artifactId>
                <executions>
                    <execution>
                        <goals>
                            <goal>build</goal>
                        </goals>
                    </execution>
                </executions>
                <dependencies>
                    <dependency>
                        <groupId>org.eclipse.che.core</groupId>
                        <artifactId>che-core-api-workspace-shared</artifactId>
                    </dependency>
                </dependencies>
                <configuration>
                    <inherited>false</inherited>
                </configuration>
            </plugin>
            ...

PR type

  • Minor change = no change to existing features or docs

Minor change checklist

  • New API required?
  • API updated
  • Tests provided / updated
  • Tests passed

Change-Id: I5eb2e2a958ffb99fc63dc6ff606a528ad105d7e0
Signed-off-by: Florent BENOIT fbenoit@codenvy.com

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current labels Sep 19, 2016
@benoitf benoitf self-assigned this Sep 19, 2016
@benoitf benoitf mentioned this pull request Sep 19, 2016
28 tasks
@codenvy-ci
Copy link

Build # 431 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/431/ to view the results.

@benoitf benoitf added this to the 5.0.0-M3 milestone Sep 20, 2016
@codenvy-ci
Copy link

Build # 446 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/446/ to view the results.

</plugins>
</build>

</project>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codenvy-ci
Copy link

…ava DTO dependencies

It allow clients of REST API of Eclipse Che to use a Typed variables instead of dynamic variables for retreieved JSON
(It includes Dashboard and Chefile CLI and other clients based on TypeScript)

input : <maven DTO modules>
ouput : dto.ts file including DTO definition and an implementation for building objects around JSON content

Change-Id: I5eb2e2a958ffb99fc63dc6ff606a528ad105d7e0
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf benoitf merged commit ea184b8 into master Sep 22, 2016
@benoitf benoitf deleted the typescript-dto branch September 22, 2016 14:14
import java.util.Map;

/**
* Helper class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide more detailed javadoc for this helper class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum ok I will provide a new PR then as it has been merged

@codenvy-ci
Copy link

Build # 481 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/481/ to view the results.

@bmicklea bmicklea mentioned this pull request Sep 28, 2016
63 tasks
@benoitf benoitf removed sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jan 23, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
…ava DTO dependencies (eclipse-che#2490)

It allow clients of REST API of Eclipse Che to use a Typed variables instead of dynamic variables for retreieved JSON
(It includes Dashboard and Chefile CLI and other clients based on TypeScript)

input : <maven DTO modules>
ouput : dto.ts file including DTO definition and an implementation for building objects around JSON content

Change-Id: I5eb2e2a958ffb99fc63dc6ff606a528ad105d7e0
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants