improve IDE iframe injection #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/505/ |
akurinnoy
approved these changes
Sep 26, 2016
ashumilova
approved these changes
Sep 26, 2016
|
I don't see what is the improvement or the reason of the change ? except hardcoding some iframe ? |
|
Now we have iframe dom injection every time when view content is loaded. Injector service tries to find an existing element with same id and deletes it. Next step - injector adds a new one iframe element. We still have problem with doubled iframe. Earlier I tried to fix it twice, but the problem still exists(hardly ever). @eivantsov showed me the new issue with doubled IDE iframe (I checked the version). |
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
olexii4
force-pushed
the
iframe_injection
branch
from
54fbdb4 to
7893750
Compare
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
improve IDE iframe injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve IDE iframe injection
Signed-off-by: Oleksii Orel oorel@codenvy.com