Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-2059 Add ssh view for workspace in UD #2980

Merged
merged 2 commits into from
Nov 8, 2016
Merged

CHE-2059 Add ssh view for workspace in UD #2980

merged 2 commits into from
Nov 8, 2016

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Nov 4, 2016

What does this PR do?

Add ssh view for workspace

What issues does this PR fix or reference?

#2059

Previous behavior

No ssh view was existing

New behavior

New tab ssh for workspace

  • allow to view default ssh key for workspace

  • allow to remove this default key

  • allow to generate default key if not present

  • view mode:
    image

  • generate mode (if no ssh key):
    image

Change-Id: Ifca18aed416f91846cf1adeb2a6e32389df196d3
Signed-off-by: Florent BENOIT fbenoit@codenvy.com

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. sprint/current labels Nov 4, 2016
@benoitf benoitf self-assigned this Nov 4, 2016
@TylerJewell TylerJewell mentioned this pull request Nov 4, 2016
14 tasks
@codenvy-ci
Copy link

Build # 922 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/922/ to view the results.

@benoitf benoitf changed the title [WiP] CHE-2059 Add ssh view for workspace in UD CHE-2059 Add ssh view for workspace in UD Nov 4, 2016
@codenvy-ci
Copy link

@benoitf
Copy link
Contributor Author

benoitf commented Nov 8, 2016

image

updates with top banner and list of ssh agents per machine (enabled or not)

@benoitf benoitf force-pushed the CHE-2059-4 branch 2 times, most recently from d601a0d to c4ff64c Compare November 8, 2016 14:10
- allow to view default ssh key for workspace
- allow to remove this default key
- allow to generate default key if not present

Change-Id: Ifca18aed416f91846cf1adeb2a6e32389df196d3
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
…ult ssh key for workspace - allow to remove this default key - allow to generate default key if not present

Change-Id: I89159e07be4872b1582c03cbbc5889bb4254b07d
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf benoitf merged commit 7e3dfe0 into master Nov 8, 2016
@benoitf benoitf deleted the CHE-2059-4 branch November 8, 2016 16:01
@benoitf benoitf removed sprint/current status/in-progress This issue has been taken by an engineer and is under active development. labels Nov 8, 2016
@benoitf benoitf added this to the 5.0.0-M7 milestone Nov 8, 2016
@slemeur
Copy link
Contributor

slemeur commented Nov 8, 2016

Thank you

@codenvy-ci
Copy link

@bmicklea bmicklea mentioned this pull request Nov 16, 2016
66 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
* CHE-2059 Add ssh view for workspace in UD
- allow to view default ssh key for workspace
- allow to remove this default key
- allow to generate default key if not present

Change-Id: Ifca18aed416f91846cf1adeb2a6e32389df196d3
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
* CHE-2059 Add ssh view for workspace in UD
- allow to view default ssh key for workspace
- allow to remove this default key
- allow to generate default key if not present

Change-Id: Ifca18aed416f91846cf1adeb2a6e32389df196d3
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants