CHE-2922: Fix Ctrl + S hotKey for Emacs. Add simple UI for incremental search. #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azatsarynnyy
reviewed
Dec 2, 2016
|
|
||
| /** | ||
| * Create StatusMessageReporterOverlay for delegation status message | ||
| * reporting to class class {@link StatusMessageReporter}. |
azatsarynnyy
approved these changes
Dec 2, 2016
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1203/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1218/ |
vparfonov
approved these changes
Dec 12, 2016
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1390/ |
…l search. Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
AndrienkoAleksandr
force-pushed
the
CHE-2992
branch
from
bfaba4b to
afc30f5
Compare
|
Build # 1647 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1647/ to view the results. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…l search. (eclipse-che#3260) Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Ctrl + S hotKey for Emacs. Add simple UI for incremental search. This UI used for straight incremental find "Ctrl + S" and for revers incremental find "Ctrl + R" on the EMACS keybinding.
What issues does this PR fix or reference?
#2992
Previous behavior
Ctrl + S hotkey combination doesn't work. And reverse incremental find (Ctrl + R) has no UI for displaying user typing.
New behavior
Ctrl + S and Strl + R works by EMACS keybinding and user typing displays on the simple special UI.
@vparfonov @azatsarynnyy @slemeur @tolusha review please.