Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced openshift-rest-client library with fabric8.kubernetes #3381

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Replaced openshift-rest-client library with fabric8.kubernetes #3381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions plugins/plugin-docker/che-plugin-docker-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,14 @@
<name>Che Plugin :: Docker :: Docker Client</name>
<properties>
<findbugs.failonerror>false</findbugs.failonerror>
<com.openshift.openshift-restclient-java.version>5.2.0-SNAPSHOT</com.openshift.openshift-restclient-java.version>
<io.fabric8.openshift-client.version>1.4.26</io.fabric8.openshift-client.version>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.openshift</groupId>
<artifactId>openshift-restclient-java</artifactId>
<version>${com.openshift.openshift-restclient-java.version}</version>
<exclusions>
<exclusion>
</exclusion>
</exclusions>
<groupId>io.fabric8</groupId>
<artifactId>openshift-client</artifactId>
<version>${io.fabric8.openshift-client.version}</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block should be in https://github.com/eclipse/che-dependencies/blob/master/pom.xml

and each dependency needs to have a CQ
I see one (your request) which is https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12209 but it's for version 1.4 while here I see 1.4.26

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review @benoitf. Indeed this code is not ready to be merged to master yet.

Are you sure that a CQ for version 1.4 (which by the way doesn't exist) isn't valid for 1.4.* versions too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l0rd AFAIK each version need to be approved as it's based on the source code provided.

IMHO migrating from 1.4.25 to 1.4.26 requires a new CQ

also if I remember, even branches should have valid CQs (only code that is not in eclipse/che repository can use any code (for example your fork)

</dependency>
</dependencies>
</dependencyManagement>
Expand Down Expand Up @@ -150,9 +146,12 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.openshift</groupId>
<artifactId>openshift-restclient-java</artifactId>
<version>5.2.0-SNAPSHOT</version>
<groupId>io.fabric8</groupId>
<artifactId>openshift-client</artifactId>
</dependency>
<dependency>
<groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId>
</dependency>
</dependencies>
<build>
Expand Down
Loading