CHE-3438: Reuse shell interpreter passed to command line to start terminal #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garagatyi
approved these changes
Dec 21, 2016
tolusha
changed the title
tolusha
changed the title
skabashnyuk
approved these changes
Dec 22, 2016
AndrienkoAleksandr
approved these changes
Dec 22, 2016
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1423/ |
|
@tolusha - when will we merge? |
|
When @evoevodin approve PR |
|
Lash him with some wet noodles, please. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1456/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…minal (eclipse-che#3458) CHE-3438: Reuse shell interpreter passed to command line to start terminal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reuse shell interpreter passed to command line to start terminal
What issues does this PR fix or reference?
#3438
Previous behavior
shwas always used as shell interpreter to execute commandsNew behavior
Reuse shell interpreter passed to command line to start terminal
Please review Che's Contributing Guide for best practices.