fix che-ip #3690
Merged
fix che-ip #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on some OS che-ip does not work because output is different. here I've added reg-ex `.*` which assume that scope can be differ from `global` and some extra words could appear like `dynamic`.
benoitf
approved these changes
Jan 12, 2017
|
Also could you check that #3564 is still ok ? |
|
@benoitf just tested with @eivantsov on digital ocean ubuntu. works. |
riuvshin
pushed a commit
that referenced
this pull request
Jan 12, 2017
on some OS che-ip does not work because output is different. here I've added reg-ex `.*` which assume that scope can be differ from `global` and some extra words could appear like `dynamic`.
|
Build # 1601 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1601/ to view the results. |
slemeur
added
the
kind/bug
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
on some OS che-ip does not work because output is different. here I've added reg-ex `.*` which assume that scope can be differ from `global` and some extra words could appear like `dynamic`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to fix #3684
on some OS che-ip does not work because output is different.
here I've added reg-ex
.*which assume that scope can be differ fromglobaland some extra words could appear likedynamic.