Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-3774 Add Eclipse Vert.x stack to default assembly #3843

Merged
merged 2 commits into from
Feb 6, 2017
Merged

CHE-3774 Add Eclipse Vert.x stack to default assembly #3843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8506bf1
CHE-3774 Add Eclipse Vert.x stack to default assembly
sbryzak Jan 21, 2017
5207236
Adding newline at the end of images-stacks file
l0rd Feb 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dockerfiles/cli/version/5.3.0/images-stacks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ eclipse/ubuntu_jdk8
eclipse/ubuntu_jre
eclipse/ubuntu_python
eclipse/ubuntu_wildfly8
registry.centos.org/che-stacks/vertx

1 change: 1 addition & 0 deletions dockerfiles/cli/version/nightly/images-stacks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ eclipse/ubuntu_jdk8
eclipse/ubuntu_jre
eclipse/ubuntu_python
eclipse/ubuntu_wildfly8
registry.centos.org/che-stacks/vertx
73 changes: 72 additions & 1 deletion ide/che-core-ide-stacks/src/main/resources/stacks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2064,5 +2064,76 @@
"name": "type-python.svg",
"mediaType": "image/svg+xml"
}
}
},
{
"id": "vert.x",
"creator": "Clement Escoffier",
"name": "Eclipse Vert.x",
"description": "Eclipse Vert.x Stack on CentOS.",
"scope": "advanced",
"tags": [
"Java",
"JDK",
"Maven",
"Vert.x",
"CentOS",
"Git"
],
"components": [{
"name": "CentOS",
"version": "---"
}, {
"name": "JDK",
"version": "1.8.0_45"
}, {
"name": "Maven",
"version": "3.2.2"
}],
"source": {
"type": "image",
"origin": "registry.centos.org/che-stacks/vertx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerJewell does it require an update of https://github.com/eclipse/che/blob/master/dockerfiles/cli/version/5.2.0/images-stacks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what's in the provided image. However, the later versions the better for Vert.x. These JDK and Maven versions are the lower bounds, any more up to date version would be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what's in the provided image.

@cescoffier: you can find the Dockerfile and other files for the image here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dharmit. So it's Maven 3.3 (the one we used).

Note for me: don't forget to update the docker file after Vert.x releases.

},
"workspaceConfig": {
"environments": {
"default": {
"machines": {
"dev-machine": {
"agents": [
"org.eclipse.che.terminal",
"org.eclipse.che.ws-agent",
"org.eclipse.che.ssh"
],
"servers": {},
"attributes": {
"memoryLimitBytes": "2147483648"
}
}
},
"recipe": {
"location": "registry.centos.org/che-stacks/vertx",
"type": "dockerimage"
}
}
},
"name": "default",
"defaultEnv": "default",
"description": null,
"commands": [{
"commandLine": "scl enable rh-maven33 'mvn clean install -f ${current.project.path}'",
"name": "build",
"type": "mvn"
}, {
"commandLine": "cd ${current.project.path} && scl enable rh-maven33 'java -jar target/*-fat.jar'",
"name": "run",
"type": "custom",
"attributes": {
"previewUrl": "http://${server.port.8080}"
}
}]
},
"stackIcon": {
"name": "type-java.svg",
"mediaType": "image/svg+xml"
}
}
]