Implement getVersion method in OpenShiftConnector #4363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
skabashnyuk
reviewed
Mar 8, 2017
| @@ -36,6 +36,11 @@ | |||
| <artifactId>guava</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.squareup.okhttp3</groupId> | |||
| <artifactId>okhttp</artifactId> | |||
| <version>3.4.1</version> | |||
There was a problem hiding this comment.
Guys. I know it's your branch. But could you follow the general rule to not to declare versions in maven submodules. It can save us some time in a future.
|
The PR requires eclipse-che/che-dependencies#34 |
l0rd
force-pushed
the
openshift-connector
branch
from
f4923c0 to
2580099
Compare
snjeza
force-pushed
the
che-97
branch
2 times, most recently
from
d96e1ec to
951d323
Compare
l0rd
force-pushed
the
openshift-connector
branch
from
cda3edc to
2627489
Compare
l0rd
force-pushed
the
openshift-connector
branch
from
54c1b89 to
c9d16a9
Compare
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
Added |
TylerJewell
added
the
target/branch
|
Can one of the admins verify this patch? |
|
work is done as part of #6222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the getVersion method in OpenShiftConnector.
OpenShift REST API has the version method, but the kubernetes client doesn't implement it. I have created a simple extension that returns version information.
What issues does this PR fix or reference?
Che doesn't start on OpenShift if the Docker socket is not mounted.