Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-3614: Rework Git commit window #5081

Merged
merged 17 commits into from
May 31, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -355,15 +355,6 @@ public interface GitLocalizationConstant extends Messages {
@Key("view.commit.title")
String commitTitle();

@Key("view.commit.all_field_title")
String commitAddAllFieldTitle();

@Key("view.commit.selection_field_title")
String commitSelectionFieldTitle();

@Key("view.commit.all_project_field_title")
String commitAllFieldTitle();

@Key("view.commit.amend_field_title")
String commitAmendFieldTitle();

Expand All @@ -376,6 +367,12 @@ public interface GitLocalizationConstant extends Messages {
@Key("view.commit.grid.comment")
String commitGridComment();

@Key("view.commit.push.checkbox.title")
String commitPushCheckboxTitle();

@Key("view.commit.nothing_to_commit.text")
String commitNothingToCommitMessageText();

@Key("view.push.title")
String pushViewTitle();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import org.eclipse.che.ide.api.resources.Project;
import org.eclipse.che.ide.api.resources.Resource;
import org.eclipse.che.ide.ext.git.client.GitLocalizationConstant;
import org.eclipse.che.ide.ext.git.client.compare.branchList.BranchListPresenter;
import org.eclipse.che.ide.ext.git.client.compare.branchlist.BranchListPresenter;

import static com.google.common.base.Preconditions.checkState;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import org.eclipse.che.ide.ext.git.client.GitLocalizationConstant;
import org.eclipse.che.ide.ext.git.client.compare.ComparePresenter;
import org.eclipse.che.ide.ext.git.client.compare.FileStatus.Status;
import org.eclipse.che.ide.ext.git.client.compare.changedList.ChangedListPresenter;
import org.eclipse.che.ide.ext.git.client.compare.changeslist.ChangesListPresenter;
import org.eclipse.che.ide.api.dialogs.DialogFactory;

import java.util.HashMap;
Expand All @@ -49,7 +49,7 @@
@Singleton
public class CompareWithLatestAction extends GitAction {
private final ComparePresenter comparePresenter;
private final ChangedListPresenter changedListPresenter;
private final ChangesListPresenter changesListPresenter;
private final DialogFactory dialogFactory;
private final NotificationManager notificationManager;
private final GitServiceClient service;
Expand All @@ -59,15 +59,15 @@ public class CompareWithLatestAction extends GitAction {

@Inject
public CompareWithLatestAction(ComparePresenter presenter,
ChangedListPresenter changedListPresenter,
ChangesListPresenter changesListPresenter,
AppContext appContext,
DialogFactory dialogFactory,
NotificationManager notificationManager,
GitServiceClient service,
GitLocalizationConstant constant) {
super(constant.compareWithLatestTitle(), constant.compareWithLatestTitle(), null, appContext);
this.comparePresenter = presenter;
this.changedListPresenter = changedListPresenter;
this.changesListPresenter = changesListPresenter;
this.dialogFactory = dialogFactory;
this.notificationManager = notificationManager;
this.service = service;
Expand Down Expand Up @@ -117,7 +117,7 @@ public void apply(Optional<File> file) throws OperationException {
for (String item : changedFiles) {
items.put(item.substring(2, item.length()), defineStatus(item.substring(0, 1)));
}
changedListPresenter.show(items, REVISION, null, project);
changesListPresenter.show(items, REVISION, null, project);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import org.eclipse.che.ide.api.resources.Project;
import org.eclipse.che.ide.api.resources.Resource;
import org.eclipse.che.ide.ext.git.client.GitLocalizationConstant;
import org.eclipse.che.ide.ext.git.client.compare.revisionsList.RevisionListPresenter;
import org.eclipse.che.ide.ext.git.client.compare.revisionslist.RevisionListPresenter;

import javax.validation.constraints.NotNull;

Expand Down
Loading