Fixed deploying of che on OCP #6656
Conversation
sleshchenko
added
status/code-review
sleshchenko
requested review from
davidfestal,
ibuziuk,
skabashnyuk,
garagatyi and
akorneta
| if [ ! -z "${OPENSHIFT_NAMESPACE_URL+x}" ]; then sed "s/ hostname-http:.*/ hostname-http: ${OPENSHIFT_NAMESPACE_URL}/" ; else cat -; fi | \ | ||
| sed "s/ image:.*/ image: \"${CHE_IMAGE_SANITIZED}\"/" | \ | ||
| sed "s/ imagePullPolicy:.*/ imagePullPolicy: \"${IMAGE_PULL_POLICY}\"/" | \ | ||
| sed "s| keycloak-oso-endpoint:.*| keycloak-oso-endpoint: ${KEYCLOAK_OSO_ENDPOINT}|" | \ | ||
| sed "s| keycloak-github-endpoint:.*| keycloak-github-endpoint: ${KEYCLOAK_GITHUB_ENDPOINT}|" | \ | ||
| sed "s/ keycloak-disabled:.*/ keycloak-disabled: \"${CHE_KEYCLOAK_DISABLED}\"/" | \ | ||
| sed "s| CHE_INFRA_OPENSHIFT_PROJECT:.*| CHE_INFRA_OPENSHIFT_PROJECT: ${CHE_INFRA_OPENSHIFT_PROJECT}|" | \ |
There was a problem hiding this comment.
are these lines needed only for ocp flavor? not for minishift or osio ?
There was a problem hiding this comment.
For minishift and osio these lines already are there
There was a problem hiding this comment.
@sleshchenko I guess for osio flavor OAUTH__TOKEN / USERNAME / PASSWORD vars are not set deliberately, so that default service account token would be used for object creation in -che namespace, right ?
There was a problem hiding this comment.
@ibuziuk you're right. I think it is useful only for OCP and minishift flavors. So, now for OSIO service account will be used for objects creation in the same project. And later, I believe, we'll implement using of users' OpenShift tokens to create workspaces' objects in different projects.
I am not sure how it will work for OCP and minishift but now it is implemented by using user token or credentials.
There was a problem hiding this comment.
sounds good. Tested on osio and all works just fine. +1 to apply
benoitf
added
the
kind/task
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4075/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4078/ |
In some cases OpenShift API responses that config map is not valid. Maybe it is because of version of APIs. It is a problem for OCP instance with openshift v3.5.5.31 and kubernetes v1.5.2+43a9be4
…ill be created for OCP and Minishift flavors
benoitf
removed
the
status/code-review
What does this PR do?
Different fixes of deploy script, especially deploying with OCP flavor.
Add ability to set OAUTH token for che-server
What issues does this PR fix or reference?
#6607