Extend NavigateToFile selenium test #6889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 18, 2017 17:51
SkorikSergey
added
the
status/code-review
|
Pr for branch che6 please. |
benoitf
added
the
kind/task
dmytro-ndp
reviewed
Oct 23, 2017
| navigateToFile.typeSymbolInFileNameField("H"); | ||
| loader.waitOnClosed(); | ||
| navigateToFile.waitFileNamePopUp(); | ||
| Assert.assertFalse(navigateToFile.waitListOfFilesNames(FILE_H_SYMBOL)); |
There was a problem hiding this comment.
Please, use static import to get rid of Assert. here to simplify the code.
dmytro-ndp
reviewed
Oct 23, 2017
| @@ -78,6 +83,9 @@ | |||
| @Inject private Menu menu; | |||
| @Inject private TestWorkspaceServiceClient workspaceServiceClient; | |||
| @Inject private TestProjectServiceClient testProjectServiceClient; | |||
| @Inject private org.eclipse.che.selenium.pageobject.git.Git git; | |||
There was a problem hiding this comment.
Please, move Git package to import section to simplify the code.
dmytro-ndp
reviewed
Oct 23, 2017
| @@ -67,6 +71,7 @@ | |||
| Arrays.asList( | |||
| "classpath (/NavigateFile_2/.che)", "classpath (/NavigateFile/.che)", | |||
| "createdFrom.con (/NavigateFile_2)", "createdFrom.api (/NavigateFile)"); | |||
| private static final String FILE_H_SYMBOL = "HEAD (/NavigateFile/.git)"; | |||
There was a problem hiding this comment.
Could you, please, add comment or better to rename the constant to explain the exact proposal of it?
dmytro-ndp
reviewed
Oct 23, 2017
| TestMenuCommandsConstants.Assistant.ASSISTANT, | ||
| TestMenuCommandsConstants.Assistant.NAVIGATE_TO_FILE); | ||
| navigateToFile.waitFormToOpen(); | ||
| loader.waitOnClosed(); |
There was a problem hiding this comment.
Waiting of closing of loader looks useless here after the NavigateToFile form had opened, doesn't it?
dmytro-ndp
reviewed
Oct 23, 2017
| @@ -124,8 +124,8 @@ public void waitFileNamePopUp() { | |||
| * | |||
| * @param text a text that should be into list | |||
| */ | |||
| public void waitListOfFilesNames(final String text) { | |||
| new WebDriverWait(seleniumWebDriver, LOAD_PAGE_TIMEOUT_SEC) | |||
| public Boolean waitListOfFilesNames(final String text) { | |||
There was a problem hiding this comment.
"Wait" doesn't require returning the value. IMHO it's better to rename method to isFilenameSuggested(nameFragment) according to the actual commands.
|
Pull request for che6 branch merged #6909. |
dmytro-ndp
approved these changes
Oct 24, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need extend NavigateToFile selenium test to cover next use cases:
What issues does this PR fix or reference?
#6641