Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more advanced TypeScript LS #7079

Merged
4 commits merged into from
Oct 30, 2017
Merged

Use a more advanced TypeScript LS #7079

4 commits merged into from
Oct 30, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2017

What does this PR do?

Introduced a new TypeScript Language Server - https://github.com/theia-ide/typescript-language-server

@ghost ghost requested review from evidolob, ashumilova and tolusha October 30, 2017 13:04
@ashumilova ashumilova added target/che6 kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 30, 2017
tolusha
tolusha reviewed Oct 30, 2017
View reviewed changes
...ts/ls-typescript/src/main/resources/installers/1.0.1/org.eclipse.che.ls.typescript.script.sh

touch ${LS_LAUNCHER}
chmod +x ${LS_LAUNCHER}
echo "nodejs ${LS_DIR}/build/language-server-stdio.js" > ${LS_LAUNCHER}
echo "typescript-language-server --stdio" > ${LS_LAUNCHER}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line

@ghost ghost merged commit 0250757 into che6 Oct 30, 2017
@ghost ghost deleted the new_ts_ls branch October 30, 2017 14:15
@skabashnyuk skabashnyuk added this to the 6.0.0-M1 milestone Nov 1, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 2, 2017
@slemeur slemeur mentioned this pull request Nov 10, 2017
Closed
@pheuter
Copy link

pheuter commented Nov 12, 2017

Does this happen to support .tsx TypeScript files with JSX react code in them? By default these files are not getting picked up by syntax highlighting or the language server.

@ghost
Copy link
Author

ghost commented Nov 13, 2017

@pheuter two issues here:

  1. https://github.com/eclipse/che/blob/master/plugins/plugin-web/che-plugin-web-ext-server/src/main/java/org/eclipse/che/plugin/web/typescript/TSLSLauncher.java#L32

I have created an issue #7323 and this will be fixed in che6 branch.

  1. Syntax coloring is provided by Orion editor. This should be fixed by Replace Orion based editor by Monaco #5330

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
6.0.0-M1
Development

Successfully merging this pull request may close these issues.
6 participants
@pheuter @evidolob @ashumilova @tolusha @benoitf @skabashnyuk