-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init and cli images should not use tag from CHE #8474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is CHE_IMAGE_TAG
used somewhere?
https://github.com/eclipse/che/blob/d6bd53abc21499e6919add8ee8d0c84075a9908a/dockerfiles/init/modules/openshift/files/scripts/ocp.sh#L69-L70
Please fix help info. Now it is not clear that CHE_IMAGE_TAG
will not be used for che-cli
and che-init
images https://github.com/eclipse/che/blob/d6bd53abc21499e6919add8ee8d0c84075a9908a/dockerfiles/init/modules/openshift/files/scripts/ocp.sh#L281
@sleshchenko thanks for your review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…migration to master * commit '47fe46a34fa1df988ed61d46e5a478e0f67675b7': (156 commits) Fixed build errors eclipse-che#6331 disable key binding handle when any 'Window' opened (eclipse-che#8473) changed info about known issue (eclipse-che#8483) Avoid removal of non-test workspaces at the cleanup environment stage of selenium testing (eclipse-che#8481) Add changes in the methods of checking git-marker in the page object 'CodenvyEditor' updated the command Use nightly stack by default and -Pdev for development Changes pvc name to a prefix + 8 random characters init and cli images should not use tag from CHE (eclipse-che#8474) CHE-7581 Improved keycloak initialization (eclipse-che#8425) CHE-8240: Switch to project explorer tab for reavel resources action. (eclipse-che#8460) Selenium: Create selenium tests to cover the authorization on GitHub (eclipse-che#8395) apply formating for 'CreateNewPackagesWithHelpCreationJavaClassTest' selenium test (eclipse-che#8464) remove read 'preferences' in try/catch block (eclipse-che#8463) add project build to CheckAutocompleteFeaturesInTheTestFolderTest (eclipse-che#8457) Selenium: Add try/catch block for displaying "Known issue" with eclipse-che#8300 bug (eclipse-che#8454) add info about known issue to FileStructureNodesTest selenium test (eclipse-che#8452) Remove "source" field from stack object (eclipse-che#8407) Selenium: Fix unexpected fail of MacrosCommandsEditorTest selenium test (eclipse-che#8441) Fix formatting (eclipse-che#8447) ...
init and cli images should not use tag from CHE, that is needed if user wants to set only custom CHE and not build init and CLI images.