Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch editors in read only mode when ws agent has stopped #9912

Merged
merged 2 commits into from
Jun 7, 2018

Conversation

RomanNikitenko
Copy link
Member

What does this PR do?

Switch editors in read only mode when ws agent has stopped

What issues does this PR fix or reference?

#9620

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

readonly

@RomanNikitenko RomanNikitenko added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jun 1, 2018
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko
Copy link
Member Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9912
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Copy link
Contributor

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion for the message

@@ -278,6 +278,7 @@ messages.startingMachine=Starting machine \"{0}\"
messages.startingOperation=Starting {0}
messages.machine.not.found=Machine {0} not found
message.projectCreated=Project {0} created
message.switch.editors.in.readOnly.mode=Workspace agent is not running, opened editors are in read only mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workspace agent is not running, open editors are switched to read-only mode

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed
thank you!

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko
Copy link
Member Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9912
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vkuznyetsov vkuznyetsov mentioned this pull request Jun 6, 2018
33 tasks
@Ohrimenko1988
Copy link
Contributor

Usecase is scheduled to covering by selenium test
#9950

@musienko-maxim
Copy link
Contributor

In the functionality which is covered by selenium tests - new regression was not found

@RomanNikitenko RomanNikitenko merged commit 2db2f5f into master Jun 7, 2018
@RomanNikitenko RomanNikitenko deleted the CHE-9620 branch June 7, 2018 08:19
@RomanNikitenko RomanNikitenko added this to the 6.7.0 milestone Jun 7, 2018
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 7, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
…he#9912)

* CHE-9620. Switch editors in read only mode when ws agent has stopped
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants