Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the list of stacks #9960

Merged
1 commit merged into from
Jun 19, 2018
Merged

Optimize the list of stacks #9960

1 commit merged into from
Jun 19, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2018 •
edited by ghost
Loading

What does this PR do?

This PR removes unused stacks and sample apps. Updated components versions. Tested most of sample commands.

What issues does this PR fix or reference?

#9899

Docs PR

eclipse-che/che-docs#419

PR to Dockerfiles repo:

eclipse-che/che-dockerfiles#190

@ghost ghost requested review from ashumilova and vparfonov as code owners June 7, 2018 15:32
@ghost ghost mentioned this pull request Jun 7, 2018
Merged
@ghost ghost changed the title Che 9899 Optimize the list of stacks Jun 7, 2018
@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jun 7, 2018
@gorkem gorkem requested a review from slemeur June 11, 2018 02:29
@slemeur
Copy link
Contributor

slemeur commented Jun 11, 2018

@vkuznyetsov : Could you please organize dedicated QA on this.
All stacks should be tested:

  • Language Servers associated with the stacks are working properly
  • Each samples have a build, run and test commands that are working

@vkuznyetsov vkuznyetsov mentioned this pull request Jun 11, 2018
Closed
33 tasks
@ghost
Copy link
Author

ghost commented Jun 11, 2018

@vkuznyetsov I suggest the following testing:

  1. In UD, click All tab in Create a Workspace screen:

image

  1. Test stacks + offered sample apps one by one.

  2. In this issue, report which combination of stack+sample did not work, with details - logs, screenshots etc.

@artaleks9 artaleks9 mentioned this pull request Jun 13, 2018
Closed
@SkorikSergey
Copy link
Contributor

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9960
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

ci-test-docker-single

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9960
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ghost ghost requested review from riuvshin and skabashnyuk as code owners June 18, 2018 10:39
@ghost ghost merged commit 0a0f243 into master Jun 19, 2018
@ghost ghost deleted the CHE-9899 branch June 19, 2018 08:41
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 19, 2018
@benoitf benoitf added this to the 6.7.0 milestone Jun 19, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashumilova ashumilova Awaiting requested review from ashumilova

@vparfonov vparfonov Awaiting requested review from vparfonov

@riuvshin riuvshin Awaiting requested review from riuvshin

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@slemeur @SkorikSergey @codenvy-ci @benoitf