Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature support multiple lang id #2256

Merged
merged 13 commits into from
Apr 16, 2024
Merged

Feature support multiple lang id #2256

merged 13 commits into from
Apr 16, 2024

Conversation

ap891843
Copy link
Contributor

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ap891843 ap891843 changed the title [DRAFT] Feature/multiple lang id support [DRAFT] Feature support multiple lang id Mar 21, 2024
@ap891843 ap891843 force-pushed the feature/multiple_lang_id_support branch from 90952e5 to eee455b Compare April 10, 2024 07:45
@Nurkambay Nurkambay marked this pull request as ready for review April 16, 2024 08:11
@Nurkambay Nurkambay changed the title [DRAFT] Feature support multiple lang id Feature support multiple lang id Apr 16, 2024
ap891843 and others added 10 commits April 16, 2024 10:16
@ap891843 @Nurkambay
feat: make cobol code layout configurable
3cefd22 
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ap891843 @Nurkambay
feat: adjust editor rulers as per the layout settings
e3e18a2 
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ap891843 @Nurkambay
feat: introduce languageId to the language server engine
d205a83 
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ap891843 @Nurkambay
chore: resolve merge conflicts
56957fd 
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ap891843 @Nurkambay
build: increase UI coverage to pass build
04b183b 
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ap891843 @Nurkambay
build: fix tests
812b3f1 
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ap891843 @Nurkambay
chore: add syntax files to the vsix
230ee53 
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@Nurkambay
Enable HP Cobol copybooks
9c07bad
@Nurkambay
Prepare for code refactor
6fd78af
@Nurkambay
Remove unused import
839c871
@Nurkambay Nurkambay force-pushed the feature/multiple_lang_id_support branch from e29e8bf to 839c871 Compare April 16, 2024 08:16
ishche
ishche approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ishche ishche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some space for improvement, but let's merge the current state first.

@Nurkambay Nurkambay merged commit 09535e3 into development Apr 16, 2024
16 checks passed
@Nurkambay Nurkambay deleted the feature/multiple_lang_id_support branch April 16, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishche ishche ishche approved these changes

@Nurkambay Nurkambay Nurkambay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ap891843 @ishche @Nurkambay