Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: use antlr to parse procedure division header #2293

Merged
merged 1 commit into from
Apr 26, 2024
Merged

wip: use antlr to parse procedure division header #2293

merged 1 commit into from
Apr 26, 2024

Conversation

ishche
Copy link
Contributor

@ishche ishche commented Apr 25, 2024

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ishche ishche force-pushed the parse-procedude-division-def branch 2 times, most recently from 0decd5c to fbd496f Compare April 25, 2024 10:16
Nurkambay
Nurkambay reviewed Apr 25, 2024
View reviewed changes
server/parser/src/main/java/org/eclipse/lsp/cobol/core/hw/Token.java Outdated
@Override
public int hashCode() {
int result = line;
result = 31 * result + startPositionInLine;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a constant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well.. it's generated throwaway code, sure)

.../src/main/java/org/eclipse/lsp/cobol/core/hw/antlradapter/ProcedureDivisionAntlrAdapter.java Outdated
@@ -117,6 +129,15 @@ private ProcedureDivisionBodyContext createProcedureDivisionBodyContext(Procedur

}

private Optional<ParseTree> findChild(ProcedureDivisionContext pdCtx, Class<?> expectedClass) {
for (ParseTree c : pdCtx.children) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

.../src/main/java/org/eclipse/lsp/cobol/core/hw/antlradapter/ProcedureDivisionAntlrAdapter.java Show resolved Hide resolved
@ishche ishche force-pushed the parse-procedude-division-def branch from fbd496f to c5beee2 Compare April 25, 2024 13:48
@ishche ishche merged commit e88db02 into development Apr 26, 2024
17 checks passed
@ishche ishche deleted the parse-procedude-division-def branch April 26, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nurkambay Nurkambay Nurkambay approved these changes

@ap891843 ap891843 Awaiting requested review from ap891843

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishche @Nurkambay