Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exp. parser id division adoption #2308

Merged
merged 1 commit into from
May 20, 2024
Merged

fix: exp. parser id division adoption #2308

merged 1 commit into from
May 20, 2024

Conversation

ishche
Copy link
Contributor

@ishche ishche commented May 20, 2024

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ishche ishche requested review from Nurkambay and ap891843 May 20, 2024 09:43
Nurkambay
Nurkambay requested changes May 20, 2024
View reviewed changes
server/test/src/main/java/org/eclipse/lsp/cobol/test/engine/UseCaseUtils.java Outdated
@@ -103,7 +103,7 @@ public static List<Diagnostic> analyzeForErrors(UseCase useCase) {
* @return the entire analysis result
*/
public static AnalysisResult analyze(UseCase useCase) {
return analyze(useCase, CobolLanguageId.COBOL);
return analyze(useCase, CobolLanguageId.EXPERIMENTAL_COBOL);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be CobolLanguageId.COBOL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups.. fixed

@ishche ishche merged commit c92ac96 into development May 20, 2024
16 checks passed
@ishche ishche deleted the hw-id-division-tail-fix branch May 20, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nurkambay Nurkambay Nurkambay approved these changes

@ap891843 ap891843 Awaiting requested review from ap891843

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishche @Nurkambay