Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mode performance metrics #2327

Merged
merged 1 commit into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,24 @@ public BenchmarkSession startSession() {
@Override
public List<Measurement> getMeasurements() {
return benchmarkSessions.stream()
.flatMap(s -> s.getMeasurements().stream())
.collect(Collectors.toList());
.flatMap(s -> s.getMeasurements().stream())
.collect(Collectors.toList());
}

@Override
public List<JsonElement> toJsons() {
Gson gson = new Gson();
return benchmarkSessions.stream()
.flatMap(s -> s.getMeasurements().stream())
.map(gson::toJsonTree)
.collect(Collectors.toList());
.flatMap(s -> s.getMeasurements().stream())
.map(gson::toJsonTree)
.collect(Collectors.toList());
}

@Override
public void logTiming() {
benchmarkSessions.forEach(this::logTiming);
}

public void logTiming(BenchmarkSession benchmarkSession) {
Collection<Measurement> measurements = benchmarkSession
.getMeasurements();
Expand All @@ -71,9 +72,12 @@ public void logTiming(BenchmarkSession benchmarkSession) {
LOG.info("Write performance data into: " + path);
Files.write(path, Collections.singleton(createHeaderLine(measurements)), StandardOpenOption.CREATE);
}
Files.write(path, Collections.singleton(createTimingLine(measurements,
String timingLine = createTimingLine(measurements,
benchmarkSession.attr("uri"),
Integer.parseInt(benchmarkSession.attr("size")))), StandardOpenOption.APPEND);
benchmarkSession.attr("language"),
Integer.parseInt(benchmarkSession.attr("lines")),
Integer.parseInt(benchmarkSession.attr("size")));
Files.write(path, Collections.singleton(timingLine), StandardOpenOption.APPEND);
} catch (IOException e) {
LOG.debug(e.getMessage(), e);
}
Expand All @@ -89,14 +93,18 @@ private String createHeaderLine(Collection<Measurement> measurements) {
line.append(",");
line.append("Total time");
line.append(",");
line.append("Language");
line.append(",");
line.append("Lines");
line.append(",");
line.append("Size");
return line.toString();
}

private String createTimingLine(Collection<Measurement> measurements, String url, int size) {
private String createTimingLine(Collection<Measurement> measurements, String url, String languageId, int lines, int size) {
StringBuilder line = new StringBuilder(url);
long total = 0;
for(Measurement m: measurements.stream().sorted(Comparator.comparing(Measurement::getId))
for (Measurement m : measurements.stream().sorted(Comparator.comparing(Measurement::getId))
.collect(Collectors.toList())) {
line.append(",");
line.append(m.getTime());
Expand All @@ -105,6 +113,10 @@ private String createTimingLine(Collection<Measurement> measurements, String url
line.append(",");
line.append(total);
line.append(",");
line.append(languageId);
line.append(",");
line.append(lines);
line.append(",");
line.append(size);
return line.toString();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ public AnalysisResult run(
StageResult<?> result = pipelineResult.getLastStageResult();

session.attr("uri", ctx.getExtendedDocument().getUri());
session.attr("language", ctx.getLanguageId().getId());
session.attr("lines", String.valueOf(ctx.getExtendedDocument().toString().split("\n").length));
session.attr("size", String.valueOf(ctx.getExtendedDocument().toString().length()));
session.attr("result", result.stopProcessing() ? "stopped" : "done");
benchmarkService.logTiming();
Expand Down
Loading